search

ruimarinho / bitcoin-core

A modern Bitcoin Core REST and RPC client.
477 stars 186 forks source link

Handle not json response #98

Closed vbrvk closed 4 years ago

vbrvk commented 5 years ago

So will be no unhandled exeptions #97

pedrobranco commented 5 years ago

@borovik96 Can you please provide the body of the bad response?

vbrvk commented 5 years ago

Actually, I do not have access to them, because of lib throws an unhandled error on production

pedrobranco commented 5 years ago

Actually, I do not have access to them, because of lib throws an unhandled error on production

You should check what's the actual Bitcoin daemon response before wrapping the code in any try catch.

Either way, as the code proposal is right now is a NACK.

pedrobranco commented 4 years ago

Closing due to inactivity.

rondorkerin commented 3 years ago

why do you close this, it's important