search

ruimarinho / docker-bitcoin-core

A bitcoin-core docker image
https://hub.docker.com/r/ruimarinho/bitcoin-core/
MIT License
367 stars 213 forks source link

CI: remove deprecated set-env, use build outputs #108

Closed torkelrogstad closed 3 years ago

torkelrogstad commented 3 years ago

set-env was removed a while ago from GitHub actions, because it was a securit risk. We replace this with the recommended workaround to get CI working again.

torkelrogstad commented 3 years ago

@ruimarinho a bit unsure of what's going on here. Is the docker password empty because I'm submitting a PR from a fork, or because you've removed it?

ruimarinho commented 3 years ago

Hmm, I see DOCKER_HUB_PASSWORD is correctly set so I need to look at what's going on.

torkelrogstad commented 3 years ago

It might work if you open a PR from this repo, with the same changes, I know that there are some restrictions on reading secrets from forks

ruimarinho commented 3 years ago

Thank you @torkelrogstad 🙏 fixed in https://github.com/ruimarinho/docker-bitcoin-core/pull/112.