search

ruimarinho / docker-bitcoin-core

A bitcoin-core docker image
https://hub.docker.com/r/ruimarinho/bitcoin-core/
MIT License
367 stars 213 forks source link

Add Bitcoin Core 23.0 #128

Closed thinkmassive closed 2 years ago

thinkmassive commented 2 years ago

Added Dockerfiles for 23.0 that are nearly the same as 22.0. The main difference was updating the gpg keys, and removing one problematic sig from SHA256SUMS.asc (using sed) for which I could not find a usable public key from any keyservers:

C388F6961FB972A95678E327F62711DBDCA8AE56
kvaciral@protonmail.com

It was found on keys.openpgp.org, however the identity was stripped, so it wasn't easily usable. I'm not sure if this is likely to eventually propagate to other keyservers, and/or the sig removed from SHA256SUMS.asc if it causes problems for many others.

A more robust solution for verifying sigs could be the updated contrib/verifybinaries/verify.py from bitcoin/bitcoin/pull/23020. Let me know if you prefer I add that file here (in 23/verify.py), or I can update it in a follow-up PR (soon or after it's merged).

Resolves #127

ruimarinho commented 2 years ago

Thank you so much @thinkmassive! Regarding the key issue, it's being tracked on https://github.com/bitcoin/bitcoin/issues/25022. I've included the asc file manually for now as workaround.

Merged in https://github.com/ruimarinho/docker-bitcoin-core/commit/ba147b689b9a78c60cf7d9fd5b20d8dfd2407e30.