search

ruimarinho / docker-bitcoin-core

A bitcoin-core docker image
https://hub.docker.com/r/ruimarinho/bitcoin-core/
MIT License
370 stars 209 forks source link

Add support for bitcoind@0.14.1 #25

Closed pedrobranco closed 7 years ago

pedrobranco commented 7 years ago

This PR adds support for bitcoind version 0.14.1.

yangwao commented 7 years ago

bump?

ruimarinho commented 7 years ago

@yangwao sorry for the lack of feedback, but something's fishy. If you take a look at https://travis-ci.org/seegno/docker-bitcoind/jobs/240583779#L1140, the hashes don't match. Let me try and find the reason for this before merging 0.14.1.

yangwao commented 7 years ago

@ruimarinho see. Looks like here is shasum hardcoded hmm https://github.com/seegno/docker-bitcoind/pull/25/files#diff-7e3c530571e5d1977f61accf9a838000R12

ruimarinho commented 7 years ago

@yangwao exactly, that's what ensures that the file hasn't been tampered with. I'm switching to the .tar.gz which is published on the bitcoin.org website as I can read the hash from the SHA256SUM signed file.

ruimarinho commented 7 years ago

@pedrobranco, deprecating this PR in favour of https://github.com/seegno/docker-bitcoind/pull/29 which brings additional changes to the alpine-based Dockerfile.