search

ruimarinho / docker-bitcoin-core

A bitcoin-core docker image
https://hub.docker.com/r/ruimarinho/bitcoin-core/
MIT License
365 stars 209 forks source link

Release new version to dockerhub #59

Closed thomaseizinger closed 6 years ago

thomaseizinger commented 6 years ago

Unfortunately, the version on dockerhub does not have the latest changes (the exposed port). Could you release a new version so that the change is available?

victorperin commented 6 years ago

Right now, i'm doing it manually. If you want you can use my fork for now: https://hub.docker.com/r/victorperin/bitcoin-core/

ruimarinho commented 6 years ago

@victorperin @thomaseizinger will work on merging changes this week. Sorry about the delay.

thomaseizinger commented 6 years ago

@victorperin Thanks! We went for creating our own image though because we needed it faster. What might be interesting though is that the whole Dockerfile can be much simpler because bitcoind is available in the alpine repository: https://github.com/coblox/docker-bitcoin-core/blob/master/Dockerfile

victorperin commented 6 years ago

No problem @ruimarinho it's normal to occur some delay sometimes.

About @thomaseizinger idea of simplifying the dokerfile, I don't agree, because repos could have some delay. (And also got the error below)

image

thomaseizinger commented 6 years ago

You have to use alpine v3.8! Then you can get the 0.16.1-r2 version. :) Yes there might be some delay but in our case, we prefer an easier to maintain Dockerfile over the latest patch release of bitcoin-core.

On Mon, 6 Aug 2018, 01:38 Victor Perin, notifications@github.com wrote:

No problem @ruimarinho https://github.com/ruimarinho it's normal to occur some delay sometimes.

About @thomaseizinger https://github.com/thomaseizinger idea of simplifying the dokerfile, I don't agree, because repos could have some delay. (And also got the error below)

[image: image] https://user-images.githubusercontent.com/5847145/43687488-55625d8e-98ac-11e8-82b9-0ac8cf7593f6.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ruimarinho/docker-bitcoin-core/issues/59#issuecomment-410528271, or mute the thread https://github.com/notifications/unsubscribe-auth/AFO3NQqg6z_XliBehWiTJOvsP-voP2Cdks5uNxFigaJpZM4Vfg1R .

ruimarinho commented 6 years ago

It's currently building on Docker Hub. I agree with @victorperin — speed is the biggest differentiation. I'm glad alpine is shipping with an updated version nowadays.