search

ruimarinho / google-libphonenumber

The up-to-date and reliable Google's libphonenumber package for node.js.
https://ruimarinho.github.io/google-libphonenumber
Other
1.39k stars 144 forks source link

Giving invalid number to a valid number #387

Open yashrawat-lanet opened 4 months ago

yashrawat-lanet commented 4 months ago

Hello,

i am using one library in frontend to verify a number and this library in backend to verify number. Frontend library is giving that number is valid but this library giving same number as invalid. I am using version - "google-libphonenumber": "^3.2.27",

Please help me. for reference i am attaching number "1203****663"

cristian-sbardelotto commented 4 months ago

@yashrawat-lanet Hello, did you solve that? I'm facing the same issue with validation.

yashrawat-lanet commented 4 months ago

@yashrawat-lanet Hello, did you solve that? I'm facing the same issue with validation.

no

cristian-sbardelotto commented 4 months ago

@

@yashrawat-lanet Hello, did you solve that? I'm facing the same issue with validation.

no

it's sad that this issue isn't being considered by the maintainers. Hope we can get some help soon

MarySnopok commented 3 months ago

+1 We are experiencing same issue , would be great if it can be looked into

ruimarinho commented 2 months ago

@yashrawat-lanet are you able to email me the actual number so I can do some debugging on my end? If not, then I suggest updating to the latest version just published to npm and check if it's being reported as valid now.

Should it actually be reporting as valid or invalid?

mcarneyupdox commented 1 month ago

@ruimarinho Is the problem that the google libraries that this is based on are not up to date in this project?

Your package-lock.json has a version from several years ago https://github.com/ruimarinho/google-libphonenumber/blob/42d8091d1a13e3ec439b63cbd727f18af57924af/package-lock.json#L4990, so it would be missing newer area codes that are included in newer versions https://github.com/google/closure-library/releases.

For testing, you could check the 656 area code that started in 2022.

ruimarinho commented 1 month ago

No, not at all. That package has nothing to do with the metadata. Basically, what you see on https://libphonenumber.appspot.com/ is what you get with this package, assuming it is up-to-date with the upstream (which it is).