Changes to work with node v8

ruimarinho / gsts

Obtain and store AWS STS credentials to interact with Amazon services by authenticating via G Suite SAML.

MIT License

222 stars 38 forks source link

Changes to work with node v8 #22

Closed dmmartins closed 4 years ago

dmmartins commented 4 years ago

Removes named regex capture and async fs methods.

ruimarinho commented 4 years ago

@dmmartins I'll merge this on a patch release but I don't intend supporting this on minor releases going forward. The reason being node 8 has been considered unmaintained for a long time and I would to like to avoid promoting the false sensation that it is a good option to stick with node 8. I understand you may be in an environment where upgrading is not an option, but hopefully the upcoming patch version remains stable enough for the foreseeable future.

ruimarinho commented 4 years ago

Merged in https://github.com/ruimarinho/gsts/commit/362d1db0fb0029781d304b16aee95010aa7e2163 and released as v2.3.1. Thanks for the PR!