search

ruimarinho / gsts

Obtain and store AWS STS credentials to interact with Amazon services by authenticating via G Suite SAML.
MIT License
212 stars 37 forks source link

Add support for credential_process #28

Closed Pluies closed 4 years ago

Pluies commented 4 years ago

Hello! 👋

This PR's goal is to add support for AWS config credential_process option (see https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-sourcing-external.html). This allows using gsts as a standard credential helper, and works cross-platform for re-obtaining STS tokens as needed. 👍

I opted to add a new option, --json, that prints out credentials to stdout in the expected format.

Let me know if there's anything else I can do to help this forward, or if there's a better way to do this :)

Thank you!

Pluies commented 4 years ago

cc @ruimarinho (sorry - forgot to assign anybody, and it looks like I can't add assignees now 🙈 )

ruimarinho commented 4 years ago

This is pretty amazing @Pluies. I wasn't aware of this feature! I'll definitely take a look. Thanks!

Pluies commented 4 years ago

Let me know if there's anything else I can do to help with this @ruimarinho 👍

ruimarinho commented 4 years ago

I'll merge this tomorrow or Saturday :) just wanted to add a test to see make sure we don't break this in the future.

ruimarinho commented 4 years ago

Thank you @Pluies! Merged in https://github.com/ruimarinho/gsts/commit/9514203852fca6a9b08b934bdbd477cf66430a00. Could you please give v2.4.1 a test?

florent-tails commented 4 years ago

@ruimarinho everything is working perfectly, thank you very much for getting this in! :)