Prevent hanging logins to non-default regions

ruimarinho / gsts

Obtain and store AWS STS credentials to interact with Amazon services by authenticating via G Suite SAML.

MIT License

222 stars 38 forks source link

Prevent hanging logins to non-default regions #45

Closed volkangurel closed 3 years ago

volkangurel commented 3 years ago

Today, gsts hangs if the sts profile is configured with a region (such as eu-west-1). This PR updates the check for the AWS console URL to also support regions in the hostname, so that redirects to a URL such as https://eu-west-1.console.aws.amazon.com/console/home?region=eu-west-1 also works.

ruimarinho commented 3 years ago

Thanks @volkangurel, looks great. I need to extract some of these functions into proper unit tests in the future.

ruimarinho commented 3 years ago

Released as 3.0.6.