search

ruimarinho / gsts

Obtain and store AWS STS credentials to interact with Amazon services by authenticating via G Suite SAML.
MIT License
222 stars 38 forks source link

Full exit on errors.RoleNotFoundError #49

Closed rustymagnet3000 closed 3 years ago

rustymagnet3000 commented 3 years ago

When the following code fires:

if (e instanceof errors.RoleNotFoundError) {
  logger.error(`Role ARN "${argv.awsRoleArn}" not found in the list of available roles ${JSON.stringify(e.roles)}`);
  route.abort();
  return;
}

gsts does not return an error code to the O/S. It appears to hang on macOS and doesn't return to the command prompt.

https://github.com/ruimarinho/gsts/blob/bde055fa130ca0e99097c8e0aee0b3c05325920e/index.js#L294

▶ gsts --version                                                                   
3.0.6
ruimarinho commented 3 years ago

@rustymagnet3000 could you give v3.0.7 on npm?

rustymagnet3000 commented 3 years ago

I can't create a new branch ( before I create a PR ) on your gsts repo.

Could you add me, please?

ERROR: Permission to ruimarinho/gsts.git denied to rustymagnet3000