search

ruimarinho / gsts

Obtain and store AWS STS credentials to interact with Amazon services by authenticating via G Suite SAML.
MIT License
212 stars 37 forks source link

Add Okta identity support #59

Closed jorgetagle closed 1 year ago

jorgetagle commented 2 years ago

Hi @ruimarinho, my company is using Okta integrated with our Google services. This causes gsts to invalidate requests made to Okta resources and the authentication process gets stuck. As a quick workaround, I added the "okta" substring into the allowed identity resources and it worked well.

https://github.com/ruimarinho/gsts/blob/d3741f4a4a2d39983ed454b4e282191adbe35c5e/index.js#L313-L317

Do you think this would be the proper solution?

dgacias commented 2 years ago

Had the same issue, solved it the same way as you mentioned: $ sudo vim +313 /usr/local/lib/node_modules/gsts/index.js

Before: if (/google|gstatic|youtube|googleusercontent|googleapis|gvt1/.test(route.request().url())) { Now: if (/google|gstatic|okta|youtube|googleusercontent|googleapis|gvt1/.test(route.request().url())) {

I can login fine now.

ruimarinho commented 1 year ago

Please give v4.1.0 a try and let me know if it's working as expected!