Spawn headful process using Node environment - Githubissues

ruimarinho / gsts

Obtain and store AWS STS credentials to interact with Amazon services by authenticating via G Suite SAML.

MIT License

217 stars 38 forks source link

Spawn headful process using Node environment #6

Closed charlespierce closed 4 years ago

charlespierce commented 4 years ago

Closes #5

Info

Currently, spawning a headful process to Authenticate relies on the assumption that gsts is on the PATH, so it fails if that assumption is violated.
Node provides us with the information we need to spawn the process directly, in process.execPath and __filename

Changes

Updated the spawning of a headful instance to spawn process.execPath (the path to the currently running Node) instead of gsts directly.
Added __filename (the path to the currently running script) to the beginning of the arguments.
The net result is that instead of calling gsts <args>, we call /path/to/node /path/to/index.js <args> directly.

Tested

Confirmed that in an environment without gsts on the PATH, the headful instance is still spawned correctly.

ruimarinho commented 4 years ago

This is fantastic! Thank you @charlespierce!

ruimarinho commented 4 years ago

Published as 2.1.4.