Open kczulko opened 1 year ago
@kczulko why wouldn't the browser download component work automatically?
@ruimarinho
I think that's because the buildPhase
in nix is pure, in the meaning that downloading something at this stage is considered as a jailbrake. If this would be allowed than the build would become unpredictable (e.g. no clear way howto calculate artifact hash etc.).
Is there an easy to test this via https://github.com/LnL7/nix-docker or similar on macOS?
Is there an easy to test this via https://github.com/LnL7/nix-docker or similar on macOS?
Basically, in such case I was using cachix/install-nix-action like e.g. here. However, this slows down the build a little bit. For this case, I would suggest moving this to separate workflow (e.g. not required to be "green" for ongoing PRs), or just leave it without testing. The latter, in case of failures would get fixed by someone from community who wants to use this installation/build recipe.
@ruimarinho @kczulko Just run into this recently while trying to install gsts
on nixos. Any chance we can get this merged? 🙏
@dephiros I am not using gsts now and it's not my top priority. You can either use my fork/branch or you may try to contribute to gsts mainline. There was no response from the maintainer for my last suggestion, which makes me think that adding gh workflow for checking this flake against arch matrix would be sufficient to merge this. I think so :thinking:
I can merge this as is but without guarantees it will work in the future due to limited testing.
@ruimarinho , seems like the node version is a bit old. I can help test it tomorrow with a newer version before we merge?
Yep, that works for me! Thanks for the help.
This does not go as I expected and definitely a bit outside of my wheel house:
buildNpmPackage
(similar to nixpkgs) but haven't gotten that approach working yet.As an alternative, I file a ticket with nixpkgs to add gsts
. . This would also allow gsts
to be installed with nix
I am very new to nodejs stack, apologies if sounds naive, is it feasable to upgrade the minimum nodejs version the project needs? That would enable the nix packaging and would also benefit the project with updates.
Hello,
I was having some problems with
aws-google-auth
(constantly returningInvalid username or password
) and one of its github issues pointed me to this project. Sinceaws-google-auth
got nixified some time ago andgsts
wasn't, I decided to write some nix expr forgsts
(I'm a nixos user) and publish it to the upstream. Not sure how good is it but it works.Notes:
playwright
installation script wants to download browser (?) so I had to disable this step via env variable. More details here.gsts
(see thedevShell
setup - chromium was added there and its path is accessible via env variable).Best regards, Karol