ruiming97 / pe

0 stars 0 forks source link

Inconsistent Data Validation for the add and find commands #5

Open ruiming97 opened 1 week ago

ruiming97 commented 1 week ago

For the add command, when we try to add a student with a name containing a numerical value, it will show an error and stop the user from doing so. However, for the find command, a name with numerical values is considered valid input as no error message is shown

Screenshot of message gotten when doing add n/Test2 p/11111111 e/test1@example.com c/CS2103T

image.png

Screenshot of message gotten when doing find n/Test2

image.png

nus-pe-bot commented 3 days ago

Team's Response

Good catch. Our Team didn't include a Name Checker, so that probably resulted in this bug. However, we'll be categorizing this as Feature Flaw. As this is a Product Design aspect, that doesn't really affect the functionality of TAHub.

Items for the Tester to Verify

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]