ruipgil / scraperjs

A complete and versatile web scraper.
MIT License
3.71k stars 188 forks source link

Potential small bug #26

Closed ahashp closed 9 years ago

ahashp commented 9 years ago

In ScraperPromise.js line 282. Do you mean to call this.doneCallBack() with (utils) ?

because I'm getting a crash onError with a stack trace like this:

TypeError: Cannot read property 'lastReturn' of undefined at doneCallback (/home/innopage/node_modules/scraperjs/src/ScraperPromise.js:28:15) at ScraperPromise._fire (/home/innopage/node_modules/scraperjs/src/ScraperPromise.js:282:9) at /home/innopage/node_modules/scraperjs/src/ScraperPromise.js:230:9 at Request.processGet as _callback at self.callback (/home/innopage/node_modules/scraperjs/node_modules/request/request.js:123:22) at Request.emit (events.js:95:17) at ClientRequest.self.clientErrorHandler (/home/innopage/node_modules/scraperjs/node_modules/request/request.js:244:10) at ClientRequest.emit (events.js:95:17) at Socket.socketOnEnd as onend at Socket.g (events.js:180:16)

ruipgil commented 9 years ago

Thanks, it's a bug definitely. Would you make a pull request, since you found the bug, or should I correct it?