search

ruipgil / scraperjs

A complete and versatile web scraper.
MIT License
3.7k stars 188 forks source link

Remove weak/node-gyp dependency #71

Open swim opened 7 years ago

swim commented 7 years ago

When running Phantom on a Windows box it defaults to requiring node-gyp. However, this is not required; please see https://github.com/amir20/phantomjs-node/tree/v1#use-it-in-windows. This should also address an old issue #2.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 99.441% when pulling 093a911fa39a90e2f4f887d5bc28290bc0c7dafe on swim:remove-weak-dep into 4ae680b84ffb40bc0b5ee70b00a955ea5368bc18 on ruipgil:master.

ruipgil commented 7 years ago

You can pass an object with those functions, when you're instantiating a dynamic scraper. I feel that this is unnecessary to be baked in. Maybe a note in the readme.