search

ruipin / fvtt-lib-wrapper

Library for Foundry VTT which provides module developers with a simple way to modify core Foundry VTT code, while reducing the likelihood of conflict with other modules.
GNU Lesser General Public License v3.0
35 stars 15 forks source link

It's breaking the auto crit damage from mid qol #5

Closed dsakura closed 3 years ago

dsakura commented 3 years ago

FVTT 0.7.9 (node) DnD5e System 1.2.0 libWrapper 1.0.5.3 Compatibily erro with Midi QOL 0.3.43 I tried to reinstall both modules and without success, I know it depends on the other module and the problem may be in it, if it is the case I will report to the author of mid qol but I thought it opportune to warn. Thank you

ruipin commented 3 years ago

Compatibily erro with Midi QOL 0.3.43

What do you mean with this? Is there an actual error message? An error in the console?

If a module that uses libWrapper simply doesn't work, it's more likely to be an issue with that module itself and I would prefer you report to them instead. If it ends up being a libWrapper bug, they're the ones who would be able to give me the information I need to debug and fix it.

dsakura commented 3 years ago

There is no error on the console. With the use of the libWrapper module, the additional damage from the critical hit does not occur automatically as before (even the critical damage hotkey from mid qol). When disabled it it works again. I tested using only the two modules at the same time, uninstalling both and reinstalling. If there is anything I can do to better check the source of the error I try. It probably happened when I updated one of the modules, or both. I sent a message to the author of mid qol too, since I can't see on the console where the error is. Thank you

ruipin commented 3 years ago

Yes, please do report this to the module author. They are probably best positioned to figure out what is wrong, and if necessary report a libWrapper issue to me.

Might also be worth trying out today's libWrapper update v1.0.7.0. While I doubt the new changes fix this issue, there is a possibility they could.

dsakura commented 3 years ago

Alright! Thank you, sorry for any inconvenience

ruipin commented 3 years ago

I'll close this for now, especially considering #7 has been created by someone working on midi-qol, probably related to this.