search

ruipin / fvtt-lib-wrapper

Library for Foundry VTT which provides module developers with a simple way to modify core Foundry VTT code, while reducing the likelihood of conflict with other modules.
GNU Lesser General Public License v3.0
33 stars 13 forks source link

add japanese localization #61

Closed BrotherSharper closed 2 years ago

BrotherSharper commented 2 years ago

I have taken the liberty to swap the english FVTT's discord link to the Japanese FVTT discord link so we can better support new users. If you would like me to revert this part of the localization I can easily do so.

ruipin commented 2 years ago

ご協力いただき、ありがとうございます。

Hopefully that is correct japanese/keigo for "Thank you for your collaboration/contribution" 😃 From my beginner-level JP knowledge (~N5), this looks great. Thanks!

As for the Discord links, you are able to easily add new ones. See e.g. the ES and PT translations. As such, I think it might be better to do the same thing as there, and include the English Discord as well in case people have EN knowledge, as that is the place that I frequent. Something like:

"support-channels": [
    {
        "title": "オンセ工房FVTTの日本支部サーバ",
        "url": "https://discord.gg/vM4YM27"
    },
    {
        "title": "FoundryVTT Discord（英語のみ）",
        "url": "https://discord.gg/foundryvtt"
    },
    {
        "title": "FoundryVTT Reddit（英語のみ）",
        "url": "https://www.reddit.com/r/FoundryVTT"
    }
]

What do you think?

BrotherSharper commented 2 years ago

@ruipin Thank you! I did indeed not know you could add custom links, I will take up your suggestion and update the pull request immediately!

BrotherSharper commented 2 years ago

I sent the update, cheers!

ruipin commented 2 years ago

This has been merged, and included in v1.11.1.0. Thanks!