ruiqimao / qmkbuilder

Online GUI for QMK Firmware
http://kbfirmware.com
GNU General Public License v3.0
383 stars 123 forks source link

Use submodule for QMK source #20

Open rswiernik opened 7 years ago

rswiernik commented 7 years ago

Currently, the QMK source is manually pulled into the repo. This opens up the possibility of errors and issues when copying in the source, as well as the possibility of falling behind of mainline QMK very quickly. From an organizational perspective, I think it would be better to have the QMK source included as a submodule. It's even pretty reasonable to pin this submodule to a specific version tag.

Thoughts? Was this looked at and passed over for some other reason I might be missing?

drashna commented 5 years ago

Considering at this point, the QMK firmware source is almost 2 years out of date...