search

ruiqimao / qmkbuilder

Online GUI for QMK Firmware
http://kbfirmware.com
GNU General Public License v3.0
383 stars 123 forks source link

KC_RSPC is invalid #21

Open incogizmo opened 7 years ago

incogizmo commented 7 years ago

Im trying to configure Space Cadet shift keys and the left shift can be set, KC_LSPO for open perentheses, but the right shift cannot, KC_RSPC, for close parentheses cannot.

Attempted to export and save the json then reupload but complained the config was invalid.

Interstingly you can set a key as KC_RSPO however this will trigger a compile error when trying to download the hex file.

tcatkins99 commented 7 years ago

I'm new to this code and QMK in general but I think this line is the issue here. It references KC_RSPO but I don't think that's a valid code. I think it should read: 'KC_RSPC': new Keycode('KC_RSPC', 'RSPC', []),

instead of 'KC_RSPO': new Keycode('KC_RSPO', 'RSPO', []),

ghost commented 7 years ago

Fixed in fe2e9525ad78c255da530921a97cb05544a1ca40, but @incogizmo has yet to close it. Just a ping; maybe you can close this yourself.