search

ruiqimao / qmkbuilder

Online GUI for QMK Firmware
http://kbfirmware.com
GNU General Public License v3.0
383 stars 123 forks source link

Map legend position to layers #6

Open BalzGuenat opened 7 years ago

ruiqimao commented 7 years ago

Could we get the help icons to line up on the right? Also figure out a way to get the button centered, since it looks kind of awkward off to the side. And the text in the textboxes centered.

We probably also want these settings saved in the json, which means the serialize() and deserialize() functions need to be changed while maintaining compatibility with older json files.

And one more thing, can we get all the functions fully documented? There are a few that don't have docstrings above them.

Other than that, looks like it works. Good job!

BalzGuenat commented 7 years ago

Thanks for the comments. I implemented your suggestions. (De-)Serialization code did not have to be changed.