ruiquelhas / vscode-uppercase

Convert selection to uppercase in Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=ruiquelhas.vscode-uppercase
MIT License
3 stars 1 forks source link

Added Extension icon #2

Closed coliff closed 7 years ago

coliff commented 7 years ago

Added icon Extension icon provided by Christian Oliff (https://github.com/coliff)

codecov-io commented 7 years ago

Codecov Report

Merging #2 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #2   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          16     16           
=====================================
  Hits           16     16

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6940546...99ebc34. Read the comment docs.

coliff commented 7 years ago

I used the online editor to make the change and it did it in a separate commit - sorry about that.

coliff commented 7 years ago

Sidenote; It'd be good to add an .editorconfig to the project so the end of file line break would be set as a preference, something like...

# editorconfig.org

root = true

[*]
charset = utf-8
end_of_line = lf
indent_size = 2
indent_style = space
trim_trailing_whitespace = true

[*.js]
insert_final_newline = true

[*.json]
insert_final_newline = true

[*.md]
trim_trailing_whitespace = false
ruiquelhas commented 7 years ago

It's just too much boilerplate for something that will probably remain unchanged for some time.