search

ruishanteo / pe

0 stars 0 forks source link

Sequence diagram for shift days extra info #21

Open ruishanteo opened 9 months ago

ruishanteo commented 9 months ago

In the following sequence diagram, lastShownList should be omitted

Screenshot 2023-11-17 at 5.22.53 PM.png

Refer to tutorial 10 answer:

Screenshot 2023-11-17 at 5.24.11 PM.png

nus-pe-script commented 9 months ago

Team's Response

In the case of the screenshot provided, "budget" should be omitted because it is the object that is being called, and hence is redundant (since it points to the activation bar of a "Budget" object). However, in the above sequence diagram, lastShownList is an object that is omitted from the sequence diagram. Thus, to make it clearer which method is being called, it was included above the arrow.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: According to the diagram, it seems that the diagram is supposed to omit details in the Logic section. As such, as much implementation details will be omitted for the ease of understanding the sequence diagram.

The inaccuracies in several different parts of this diagram makes this level of inclusion of details inconsistent throughout the whole diagram.

In this issue #450, the title of the object is :Ui but the method was still not specified as MainWindow.handleChangeTheme() because this mention is unnecessary.

Screenshot 2023-11-22 at 9.47.05 AM.png

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]