Open ruishanteo opened 9 months ago
Accepted as the Staff object was just obtained from the model, however the reference is indeed copied over to a new variable. Thus, the diagram is not entirely accurate, but this error does not greatly affect the conceptual cohesion of the model and it can still be understood.
Team chose [severity.Low
]
Originally [severity.Medium
]
Reason for disagreement: The entire sequence diagram consists of too many inconsistencies (along with other bugs reported) to keep the sequence diagram still understandable.
:Logic
instead of :ShiftCommand
to minimise details provided in the Logic component. (refer to forum issue #450):Ui
but the method was still not specified as MainWindow.handleChangeTheme()
because this mention is unnecessary.:Model
which is an interface. It should be :ModelManager
.As the object added is created inside the Logic component (i.e., by the Parser), it should appear inside the Logic component (i.e., similar to the second diagram)
The sequence diagram, with these reasons above, is not correctly depicting the implementation details at all. Thus, I disagree that the errors do not greatly affect the conceptual cohesion of the model and (the diagram) can still be understood.
These errors together makes the intention of the sequence diagram hard to understand. As a tester, I do not know what details are trying to be included and what are omitted since they are not consistently omitted or included.
There should be at least one bug report on the sequence diagram that has medium severity.
here, there is a s:Staff object created but according to the code I don't think there is a new staff object created. It was only obtained from the model.