ruishanteo / pe

0 stars 0 forks source link

Unable to remove single affiliation #4

Open ruishanteo opened 9 months ago

ruishanteo commented 9 months ago

According to the UG, I am able to:

but I am not able to remove an affiliation for a person.

Without this remove feature, the affiliation history related features are less useful since the affnh should return a person's past affiliations as well.

soc-pe-bot commented 9 months ago

Team's Response

Thank you for the suggestion tester! We developed the commands in the order of their importance. While we agree that allowing for the deletion of a single affiliation will be a good addition, it may not be as useful as the other commands since patients tend to be assigned to a particular group of nurses or doctors in the long run. So we foresee that the only time we have to remove a particular patient from affiliation is when they leave the hospital, which we can remove from affiliation by simply deleting them from the contact list.

There is indeed some validity in the interaction with affiliation history. In a case where the removal of a patient is necessary although the patient has not left the hospital, we still allow it using the edit command although we have to reinput existing affiliations. So we deem this as a feature that can be implemented in the future.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: In developing features, the core of every feature should be CRUD. CRD are the most essential and should be included.

Here, there is no way to delete an affiliation other than to clear them all at once.

This is a feature flaw.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** Affiliations is a key feature in the app. These are the features in the app: All roles: 1. add a person 2. listing all persons 3. editing a person 4. find a person 5. delete a person 6. add affiliations 7. find all affiliations of specified person 8. listing affiliation history 9. deleting affiliation history 10. specialisation of doctor 11. add next of kin 12. add shift dates 13. find who is on duty Quite a sizeable number of features include affiliation. There is add and find for affiliation. The inclusion of affiliation history feature is also important when affiliations are deleted (which they cannot be singularly). There is no point having feature 8 and 9, if affiliations cannot be deleted. In the scenario raised, imagine a patient with 2 doctors and 2 nurses. If 1 of the nurses is unassigned to said patient, users can only remove all affiliations and add the 2 doctors and 1 nurse back, through the edit person command.