search

ruithnadsteud / yt_georaster

A package for handling geotiff files and georeferenced datasets within yt.
1 stars 2 forks source link

Milestone 1 demo notebook #12

Closed arevill2 closed 3 years ago

arevill2 commented 3 years ago

Updated Milestone 1 jupyter notebook file (see: ... yt_geotiff/examples/Milestone_1_demo.ipynb).

deastwoo commented 3 years ago

The notebook looks great Andrew! The only thing I would suggest is really minor. Just rename the function you have for getting the centroids getXY_pixel to something more relevant like get_centroid_XY. It might be a bit confusing to include pixel unless I am misunderstanding. Also, looking at it by eye the comparison between imshow and the slice plot seems pretty much exact to me! It would be cool to see the same colourmap in imshow but it is not an issue.

arevill2 commented 3 years ago

The notebook looks great Andrew! The only thing I would suggest is really minor. Just rename the function you have for getting the centroids getXY_pixel to something more relevant like get_centroid_XY. It might be a bit confusing to include pixel unless I am misunderstanding. Also, looking at it by eye the comparison between imshow and the slice plot seems pretty much exact to me! It would be cool to see the same colourmap in imshow but it is not an issue.

Thanks Dan. Good suggestions. I will add.