ruithnadsteud / yt_georaster

A package for handling geotiff files and georeferenced datasets within yt.
1 stars 2 forks source link

S2 compatibility #19

Closed arevill2 closed 3 years ago

arevill2 commented 3 years ago

Updates:

arevill2 commented 3 years ago

Hi @brittonsmith, the yt_geotiff updates enabling the read, up/downsampling and ploting of Sentinel-2 band files has been added to the "S2 compatability" pull request. Also, added "pip install scipy=1.6.1" to the config.yml file. All current tests (not including those in PR: Circleci tests) have completed successfully.

arevill2 commented 3 years ago

Hi @brittonsmith. All comments resolved. I guess the 'README.md' now needs updating to reflect the resampling functionality(?)

brittonsmith commented 3 years ago

Looks like you've also got one flake8 error.

arevill2 commented 3 years ago

The flake8 error is where I reinstated the 'ad' function: yt_geotiff/data_structures.py:167:9: F841 local variable 'ad' is assigned to but never used

arevill2 commented 3 years ago

Ok. flake8 error now fixed.