search

ruithnadsteud / yt_georaster

A package for handling geotiff files and georeferenced datasets within yt.
1 stars 2 forks source link

Add GeoScience fields #21

Closed brittonsmith closed 3 years ago

brittonsmith commented 3 years ago

This implements machinery for adding some applied geo-science fields. We also add functionality to create band name aliases for the highest resolution version of a band available. For example, if we have both B01_20m and B01_10m, the B01 field is created as an alias to B01_10m.

Fields added:

With this, one can do:

ds = yt.load(...)
rec = ds.rectangle...
rec["bands", "ndwi"]
brittonsmith commented 3 years ago

@arevill2 mostly minor comments, everything looks pretty good. I think there are two outstanding issues that we can either try to fix now or at least document them for fixing later:

  1. including files from different directories doesn't work
  2. the rasterio group dataset doesn't support including multi-band geotiffs

I'm fine if we want to save these for after the milestone.

I also noticed there are two versions of the m2 notebook. Since it's almost done, I think we should remove whichever one we're not using to avoid confusion.

It would also be great to include some tests using some of the new test data. Perhaps the tests could just do a handful of the things we show off in the notebook.

arevill2 commented 3 years ago

Edits applied in response to @brittonsmith previous comments. Most notably, edits have been added to: