ruithnadsteud / yt_georaster

A package for handling geotiff files and georeferenced datasets within yt.
1 stars 2 forks source link

The naming of sentinel 2 bands based on filenames should be cleaner #28

Closed deastwoo closed 3 years ago

deastwoo commented 3 years ago

I'm not sure if this is an issue just for sentinel 2 data but this is the example I came across.

If I have a folder of sentinel 2 jp2s and a file doesn’t conform to the expected format, the alias given to the band can get a weird name. To avoid getting a band named S2_10m had to rename my mask files from e.g. MSK_CLDPRB_20m.jp2 to <sentinel 2 scene id code>_<datetime string>_MSKCLDPRB_20m.jp2. This gives a neater band name S2_MSKCLDPRB but I don't think we want a user to have to rename the files in this way.

I am not sure what the best solution would be. I don't think we need to prepare to deal with every possible filename. The naming of bands should be more simple, or at least have an extra check to see if the band matches the format the aliasing is expecting.

brittonsmith commented 3 years ago

Resolved in PR #38.