search

ruiyan1995 / Group-Activity-Recognition

A novel Participation-Contributed Temporal Dynamic Model for Group Activity Recognition
25 stars 6 forks source link

the code may be wrong #11

Open beibeirory opened 4 years ago

beibeirory commented 4 years ago

https://github.com/ruiyan1995/Group-Activity-Recognition/blob/435bee845cd3fc66e9d27a0d02479ff71f0346ba/Pre/VD_Track.py#L37

Thanks for releasing the code. You sort the filenames, but they are str. If test this code with the video 1/9995, we will not get the correct results.

ruiyan1995 commented 4 years ago

Thank you for your remind, I have debugged the error in the VD_Track.py. It may not affect CAD_Track.py

ruiyan1995 commented 4 years ago

I hope it works!

fabiozappo commented 4 years ago

Hello, i noticed same problem occurs on following folders:

1/9995 52/9975 52/10015 54/9990

https://github.com/ruiyan1995/Group-Activity-Recognition/blob/435bee845cd3fc66e9d27a0d02479ff71f0346ba/Pre/VD_Track.py#L37

Thanks for releasing the code. You sort the filenames, but they are str. If test this code with the video 1/9995, we will not get the correct results.

ruiyan1995 commented 4 years ago

Hello, i noticed same problem occurs on following folders:

1/9995 52/9975 52/10015 54/9990

https://github.com/ruiyan1995/Group-Activity-Recognition/blob/435bee845cd3fc66e9d27a0d02479ff71f0346ba/Pre/VD_Track.py#L37

Thanks for releasing the code. You sort the filenames, but they are str. If test this code with the video 1/9995, we will not get the correct results.

I have debugged the error as follow,

img_list = sorted(glob.glob(os.path.join(self.dataset_folder, video_id, frame_id, "*.jpg")))[16:26]

img_list = glob.glob(os.path.join(self.dataset_folder, video_id, frame_id, "*.jpg")) img_list = sorted(img_list, key=lambda x:int(x.split('/')[-1].split('.')[0]))[20-int((self.num_frames-1)/2):21+int(np.ceil(float(self.num_frames-1)/2.0))]

Please check it again!