ruiyangzh / pe

0 stars 0 forks source link

Duplicate detection should be stronger #10

Open ruiyangzh opened 12 months ago

ruiyangzh commented 12 months ago

Creating two persons with the same name and all other fields, but different case, is allowed with no warning. There should at least be a warning, to prevent cases where users accidentally create two contacts and clutter their list. Not a major issue however.

Capture.PNG

Capture.PNG

nus-se-bot commented 12 months ago

Team's Response

duplicate of #3842 as both are targetting the duplication of names.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Duplicating person due to over zealous input cheking

Screenshot 2023-11-17 at 4.19.00 PM.png

In this example, the same person john doe can be added thrice due to differences in the case sensitive and adding space between john and doe. In the real word example, names are not being differentiated with case sensitivity. So this example does not really capture the real world, just a minor error.


[original: nus-cs2103-AY2324S1/pe-interim#3008] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for spotting the bug!

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]