ruiyangzh / pe

0 stars 0 forks source link

Editing someone without changing any details still changes the Last Modified date #3

Open ruiyangzh opened 12 months ago

ruiyangzh commented 12 months ago

One would expect editing without changing any details to count as not being 'modified'. However this is not true in the current version.

See:

Before: Capture.PNG

After: Capture.PNG

nus-se-script commented 12 months ago

Team's Response

As per the UG, this is expected behaviour, so the type has been changed to a FeatureFlaw

image.png

In addition, the team posits that the behaviour is logical & likely to be expected:

  1. The edit command is introduced to the user as editing the values at the index.
  2. The edit command currently reports that the edit was successful (To our knowledge, the question of whether edit should accept such inputs was raised in another bug report as a separate issue)
  3. As such, the system currently reports that an edit operation was successful, and that something was edited.
    1. To be specific, a value (e.g. name) was edited to a copy of itself. In other words, if the person's name was John, the edit John ==> John was made.
    2. This implies that modification occurred. The modification just so happened to be from something to itself.
  4. As such, it is perfectly reasonable that a user would expect that this successful edit operation would update the Last Modified Date Time field.
    1. This is especially as the User Guide explicitly states that the edit command updates the field upon successful execution.

Hence, the current behaviour is, if you assume that leaving Last Modified un-edited is also reasonable, at worst an arbitrary decision between two reasonable alternatives (as per the reasonable-ness argument in point 4.).

However, the team posits that it is in fact more likely that, given the other factors, that the current behaviour is in fact more reasonable.

Hence, the team puts forth the idea that the current behaviour is not a FeatureFlaw

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]