Package hashes depend on the engine version of the PF Sandbox running.
This makes sense and isn't something I want to change.
This doesn't affect netplay as netplay recalculates the hash and all clients need to be running the same PF Sandbox git commit anyway.
However this will affect the package quick checks for local tournament play.
People running newer version of PF Sandbox will have the hash check fail due to the json upgrade code changing the engine_version + whatever the required upgrade is.
Solution 1
Create a mechanism for the package source webserver to automatically update the package to the latest version.
However that the means the user should always be on the latest PF Sandbox or the package updates that get downloaded wont work.
This means I would also need some sort of mechanism for auto-updating PF Sandbox.
This would replace the builds page on the website: https://github.com/rukai/pf_sandbox_infra/blob/master/website/templates/builds.html.hbs
Solution 2
Provide hashes for each future engine_version the package is available for.
Might be easier to implement by git commits instead of engine_version but would be less efficient.
Will need to implement a package server to handle this though.
The package server will need to be able to run many PF Sandbox versions.
Solution 3
Simply tell the user why the package hash check is failing.
If the engine version is too old then tell the user which version of PF Sandbox they need to use OR that the check failed because they are using a newer version.
If the engine version is too new it wont even reach this point anyway.
Package hashes depend on the engine version of the PF Sandbox running. This makes sense and isn't something I want to change. This doesn't affect netplay as netplay recalculates the hash and all clients need to be running the same PF Sandbox git commit anyway. However this will affect the package quick checks for local tournament play. People running newer version of PF Sandbox will have the hash check fail due to the json upgrade code changing the engine_version + whatever the required upgrade is.
Solution 1
Create a mechanism for the package source webserver to automatically update the package to the latest version. However that the means the user should always be on the latest PF Sandbox or the package updates that get downloaded wont work. This means I would also need some sort of mechanism for auto-updating PF Sandbox. This would replace the builds page on the website: https://github.com/rukai/pf_sandbox_infra/blob/master/website/templates/builds.html.hbs
Solution 2
Provide hashes for each future engine_version the package is available for. Might be easier to implement by git commits instead of engine_version but would be less efficient. Will need to implement a package server to handle this though. The package server will need to be able to run many PF Sandbox versions.
Solution 3
Simply tell the user why the package hash check is failing. If the engine version is too old then tell the user which version of PF Sandbox they need to use OR that the check failed because they are using a newer version. If the engine version is too new it wont even reach this point anyway.