[Bug] More than 100% download completion

rule110-io / surge

Surge is a p2p filesharing app designed to utilize blockchain technologies to enable 100% anonymous file transfers. Surge is end-to-end encrypted, decentralized and open source.

https://getsurge.io

Apache License 2.0

428 stars 50 forks source link

[Bug] More than 100% download completion #28

Closed MutsiMutsi closed 3 years ago

MutsiMutsi commented 3 years ago

Describe the bug A download can be marked as more than 100% completed, in this scenario the download also never finishes.

To Reproduce Steps to reproduce the behavior:

Download a file
A chunk was not received on time, a new request gets sent out
Both the initial and retried chunk are received and counted towards progress

Expected behavior Dont double count a chunk. Dont check for incoming bytes but rather chunk bitmap for file progress/completion.

Screenshots

MutsiMutsi commented 3 years ago

fixed in 0.2.1-beta