search

rules-proto-grpc / rules_proto_grpc

Bazel rules for building Protobuf and gRPC code and libraries from proto_library targets
https://rules-proto-grpc.com
Apache License 2.0
253 stars 160 forks source link

csharp still generates Grpc.Core? #224

Closed loeffel-io closed 1 year ago

loeffel-io commented 2 years ago

Issue Description

Hello, I try to compile my proto grpc defintions to csharp Grpc.Net.Client instead of Grpc.Core with https://github.com/rules-proto-grpc/rules_proto_grpc which should include this since 4.2.0 but csharp_grpc_compile still generates Grpc.Core

Log Output

No response

rules_proto_grpc Version

4.2.0

Bazel Version

5.3.2

OS

darwin arm64

Link to Demo Repo

No response

WORKSPACE Content

No response

BUILD Content

No response

Proto Content

No response

Any Other Content

No response

aaliddell commented 1 year ago

Yes, this is something I have observed as well. The generated .cs files continue to reference Grpc.Core in the grpc version currently used by release 4.2.0. I have not checked if this has changed in the latest release of the grpc dotnet plugin.

aaliddell commented 1 year ago

This appears to be expected behaviour of the upstream plugins, as the examples on grpc-dotnet still continue to reference Grpc.Core and the Grpc.Net.Common package still depends on Grpc.Core.Api