search

rules-proto-grpc / rules_proto_grpc

Bazel rules for building Protobuf and gRPC code and libraries from proto_library targets
https://rules-proto-grpc.com
Apache License 2.0
253 stars 160 forks source link

Fix capitalization on Objective-C outputs containing digits #253

Closed danny-skydio closed 1 year ago

danny-skydio commented 1 year ago

The function in objectivec_helpers.cc that's referenced also splits segments if they come after a digit, which wasn't being handled correctly.

e.g. vector3f -> Vector3F

This sadly makes this function a lot more complicated (read: gross), I naively transliterated the function, so I have no doubt that this could be made way better. Specifically, I'd be slightly concerned about starlark performance if you were using this for some absurd number of types.

Anyway, regardless of actual implementation, this fixes a bug I was hitting that I suppose was rather obscure.

aaliddell commented 1 year ago

Thanks, that's an 'interesting' implementation they have :laughing: