search

rules-proto-grpc / rules_proto_grpc

Bazel rules for building Protobuf and gRPC code and libraries from proto_library targets
https://rules-proto-grpc.com
Apache License 2.0
250 stars 157 forks source link

Explicitly specify platforms version to use. #263

Closed echochamber closed 1 year ago

echochamber commented 1 year ago

Currently we default to rules_proto version which, which is out of date and missing @platforms//os:fuchsia. This causes any downstream rulesets that are configuring using this constraint (rules_rust) to fail to build.

Error message:

no such target '@platforms//os:fuchsia': target 'fuchsia' not declared in package 'os'

https://github.com/protocolbuffers/protobuf/blob/aad52db8a16ea9ae4cc5b504ad2aea1ba8b0e5a7/WORKSPACE#L15-L20

aaliddell commented 1 year ago

We never use the @platforms repo within these rules, so I'd prefer to avoid adding yet-another-dep when the conflict here is between two external rulesets (rules_proto and rules_rust). The preferred method for forcing a newer platforms version when required would be to declare it prior to loading rules_proto_grpc in your WORKSPACE and that version will 'win'; see https://rules-proto-grpc.com/en/latest/overriding_deps.html

Let me know if I've misunderstood though