search

rules-proto-grpc / rules_proto_grpc

Bazel rules for building Protobuf and gRPC code and libraries from proto_library targets
https://rules-proto-grpc.com
Apache License 2.0
250 stars 157 forks source link

handling "." in python_path #271

Closed chasezheng closed 10 months ago

chasezheng commented 1 year ago

In the helper function that handles python_path https://github.com/rules-proto-grpc/rules_proto_grpc/blob/cbdb484f0f605f246e0d073865809320c80920cc/internal/common.bzl#L166

It would be helpful to add ".replace('.', '/')". I think that's the actual behavior of the python plugin.

aaliddell commented 1 year ago

Do you have an example of where this is necessary? As far as I am aware the python plugins don't emit files under subdirectories that would necessitate this conversion

github-actions[bot] commented 10 months ago

This issue has been automatically closed because there has been no response to our request for more information from the original author. With only the information that is currently in the issue, we don't have enough information to take action. Please reach out if you have or find the answers we need so that we can investigate further.