rules-proto-grpc / rules_proto_grpc

Bazel rules for building Protobuf and gRPC code and libraries from proto_library targets
https://rules-proto-grpc.com
Apache License 2.0
256 stars 159 forks source link

Enable full features for tokio and tokio-stream for Rust #284

Closed kuenishi closed 9 months ago

kuenishi commented 1 year ago

To get many powerful features such as multi-thread and macros in Tokio, we'll need this. I believe this would be more practical than to have in vanilla dependency.

Having the bazel-built and full-featured Rust gRPC system out of the box will definitely wonderful.

aaliddell commented 11 months ago

Is this not something that the application level crate dependencies should be declaring? We don't appear to need "full" to support building the protobuf and grpc libraries that applications then consume and would prefer not to be supporting unnecessary dependencies in the tree.