search

rules-proto-grpc / rules_proto_grpc

Bazel rules for building Protobuf and gRPC code and libraries from proto_library targets
https://rules-proto-grpc.com
Apache License 2.0
256 stars 159 forks source link

C# module doesn't build. Missing rules_dotnet definition. #288

Closed fesodre closed 1 year ago

fesodre commented 1 year ago

Issue Description

It seems that https://github.com/rules-proto-grpc/rules_proto_grpc/commit/38f4d414244ce3bebfc132917ffaba8381b36dea changed all references of @io_bazel_rules_dotnet to @rules_dotnet, but there's no repo definition for it so bazel can't build it.

Log Output

$ bazel build //csharp/...
ERROR: Traceback (most recent call last):
        File "/home/fesodre/rules-proto-grpc/rules_proto_grpc/csharp/repositories.bzl", line 5, column 6, in <toplevel>
                "rules_dotnet",
Error: file '//:repositories.bzl' does not contain symbol 'rules_dotnet'
ERROR: Error computing the main repository mapping: initialization of module 'csharp/repositories.bzl' failed
Loading:

rules_proto_grpc Version

38f4d41

Bazel Version

6.3.2

OS

14-Ubuntu SMP x86_64 GNU/Linux

Link to Demo Repo

No response

WORKSPACE Content

No response

BUILD Content

No response

Proto Content

No response

Any Other Content

No response

aaliddell commented 1 year ago

Hmm curious, I don't know why that ended up in that commit; was probably in a rush to get the release finished... :facepalm:

As a side note though: the head commit is not guaranteed to be in any stable state between release tags and the 4.5.0 tag is on the commit prior to that so is safe to use.

aaliddell commented 1 year ago

Reverted in aa1786dd77140d727c89311ffe63588a31e86c8a