Closed shs96c closed 9 months ago
Yes you need to add those dependencies as documented in the per-lang docs: https://rules-proto-grpc.com/en/latest/lang/python.html#python-grpc-library. These have to be done by you at top level WORKSPACE, since we cannot both declare a dependency and load
from it within rules_proto_grpc_repos
or similar.
@aaliddell I'm sorry, but where are these extra dependencies documented? There don't seem to be any mention of additional dependency requirements on the link you shared. Is it the extra_deps()
? Searching for the exact missing dependency yields 0 results: https://rules-proto-grpc.com/en/4.5.0/search.html?q=build_bazel_rules_apple&check_keywords=yes&area=default#
In the workspace section of the 4.5.0 docs there's a load and call to the extra deps: https://rules-proto-grpc.com/en/4.5.0/lang/python.html#id21
load("@rules_proto_grpc//python:repositories.bzl", rules_proto_grpc_python_repos = "python_repos")
rules_proto_grpc_python_repos()
load("@com_github_grpc_grpc//bazel:grpc_deps.bzl", "grpc_deps")
grpc_deps()
load("@com_github_grpc_grpc//bazel:grpc_extra_deps.bzl", "grpc_extra_deps")
grpc_extra_deps()
Issue Description
After loading
//:repositories.bzl
and callingrules_proto_grpc_repos
, dependencies required bycom_github_grpc_grpc
are not loaded, notablybuild_bazel_rules_apple
, which is used by grpc_build_system.bzl.All the deps would be loaded properly if
@com_github_grpc_grpc//bazel:grpc_dep.bzl
was loaded andgrpc_deps()
called.Log Output
rules_proto_grpc Version
4.3.0
Bazel Version
6.3.2
OS
macOS
Link to Demo Repo
No response
WORKSPACE Content
No response
BUILD Content
No response
Proto Content
No response
Any Other Content
No response