search

rules-proto-grpc / rules_proto_grpc

Bazel rules for building Protobuf and gRPC code and libraries from proto_library targets
https://rules-proto-grpc.com
Apache License 2.0
249 stars 156 forks source link

Handling paths with dots in Python rules #301

Closed linzhp closed 8 months ago

linzhp commented 8 months ago

Some proto packages have dots in their paths. Python rules should replace them with /, otherwise Bazel won't be able to find the output files, leading to build errors like:

ERROR: /home/user/code/k8s.io/apimachinery/pkg/api/resource/BUILD.bazel:4:14: Generating Python proto_library //k8s.io/apimachinery/pkg/api/resource:resourcepb_proto failed: not all outputs were created or valid
aaliddell commented 8 months ago

Great, thanks! I'll fix the diff error post merge