search

ruliang / reallysimplehistory

Automatically exported from code.google.com/p/reallysimplehistory
Other
0 stars 0 forks source link

Figure out what meaningless condtional was supposed to do in iframeloaded #25

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The following code appeared in RSH0.4:

/*Move to this location in the browser location bar if we are not dealing
with a page load event*/
   if (this.pageLoadEvent != true) {
      window.location.hash = hash;
   }

The only problem is, there was never any dhtmlHistory member called
pageLoadEvent. Since this code has been in production for years, and
worked, I just removed the conditional since it was always evaluating to true.

It would be nice to figure out what this was supposed to do, though.

Original issue reported on code.google.com by bdpathfi...@gmail.com on 8 Nov 2007 at 7:28

GoogleCodeExporter commented 9 years ago

Original comment by bdpathfi...@gmail.com on 8 Nov 2007 at 7:28

GoogleCodeExporter commented 9 years ago 
I'm trying to remember what that was supposed to do ;)

I think the intent there was to differentiate between the page loading the 
first time
and the iframe changing. It must be some old code that I forgot to refactor 
out, kind
of like the human appendix. It seems safe to remove.

Original comment by bradneub...@gmail.com on 9 Nov 2007 at 6:43

GoogleCodeExporter commented 9 years ago 
Removed. Thanks to Brad for helping me confirm that was OK!

Original comment by bdpathfi...@gmail.com on 13 Nov 2007 at 5:35