ruliang / reallysimplehistory

Automatically exported from code.google.com/p/reallysimplehistory
Other
0 stars 0 forks source link

Safari 3.x not supported by version 0.6 #77

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. use Safari v 3.x (current on Windows is 3.2.1)
2. try to use rsh library

What is the expected output? What do you see instead?
Expected it to work but it didn't.  Lots of flaky behavior.

What version of the product are you using? On what operating system?
0.6, Windows

Please provide any additional information below.

I spent all day trying to get my page working with rsh on Safari and it was 
driving me crazy.  It 
took a lot of searching to find mention of the fact that 0.6 does not support 
newer versions of 
Safari.

The fix is simple: dont' set isSafari if navigator.version is >= 3.0.  The base 
(Gecko) code seems 
to work fine on that platform (although I haven't done extensive testing).

I found mention of this on the "wiki" under "Usage examples" (or somesuch); way 
at the bottom, 
of all places.  Maybe I'm just clueless, though.

I'm hoping a nice obvious "issue" will help others.

rsh is great, otherwise :-)

Looking forward to 0.8.

BTW, this code in checkLocation() doesn't make any sense (to me):
        /*If we are dealing with IE and we are in the middle of making a location change from 
an iframe, ignore it*/
        if (!this.isIE && this.ieAtomicLocationChange) {
            return;
        }

Seems like that check should be for "this.isIE," no?

Original issue reported on code.google.com by william....@gmail.com on 10 Jan 2009 at 4:23

GoogleCodeExporter commented 9 years ago
I agree. Safari 4/Win flakey, too, when RSH runs under isSafari. Hacking RSH to 
use
isGecko seems to make Safari 4/Win work.

Original comment by banks...@gmail.com on 16 Jul 2009 at 10:38