Closed jstnlef closed 7 years ago
Good catch! I'm not sure how we're going to do version support in the future after Ruma has been released a few times and a new version of the spec has come out since the first release. Prior to the initial release of Ruma, at least, we'll just keep tracking whatever the latest version of the spec is. In this case, we should bump the supported version to 0.2.0, and again for 0.3.0 when that comes out.
The new supported
constructor you added seems good. In fact, we can just removed the basic new
constructor now, and supported
can initialize the struct directly.
I'll make those changes shortly 👍
Looks good. Can you squash down to one commit? Then I'll merge it!
Squashed 👍
Originally the response returned as
where the spec defines it to return as
This should fix that. However, I have another question, is the expectation that ruma will support all versions of the spec? At the very least I believe it should be supporting the most recent one. Let me know and I can modify or add as needed.