search

ruma / homeserver

A Matrix homeserver written in Rust.
https://www.ruma.io/
1.08k stars 41 forks source link

Removing duplication in Clap app specification #124

Closed jstnlef closed 7 years ago

jstnlef commented 7 years ago

I noticed that both the name and the description were duplicates of the ones specified in Cargo.toml. I figure it makes sense for them to be driven by those values so I made the change. Let me know what you think. (There's also a mild amount of OCD in there in moving name and version to the top 😛 )

jimmycuadra commented 7 years ago

Using the Cargo env vars for Clap is good, but changing the order of keys in Cargo.toml should be reverted. It's alphabetical, and gets set that way when using cargo add and cargo rm from the cargo-edit plugin. It'll just end up getting changed back.

jstnlef commented 7 years ago

Ah fair enough. I should have known they were alphabetical. Silly me. Reverting 👍

jimmycuadra commented 7 years ago

Squash down to one commit and I'll merge. Thanks!

jstnlef commented 7 years ago

Squashed