search

ruma / homeserver

A Matrix homeserver written in Rust.
https://www.ruma.io/
1.08k stars 41 forks source link

Don't allow registering usernames with uppercase letters #172

Closed jansol closed 5 years ago

jansol commented 7 years ago

The spec allows this, but it's constantly causing problems. As I see it, disallowing registration of such ids in ruma is the easiest step to mitigate the issue for now.

jansol commented 7 years ago

Actually, I'm not sure if the spec allows it any more -- synapse apparently does though.

mujx commented 7 years ago

That seems like an issue with the spec and an issue should be opened there. By the way what were the problems from this?

jansol commented 7 years ago

People frequently create accounts with capitalised initials etc, and then get confused when they can't login or their invitations never arrive because they tried to write it all lowercase.

mujx commented 7 years ago

Also having the same username with different capitalization is annoying. Perhaps a better UI/UX on the client or some normalization on the server would prevent these kind of problems.

Better open an issue on the matrix-doc.

aaronraimist commented 5 years ago

Spec has been clarified, ruma-identifiers only allows lowercase and has a test: https://github.com/ruma/ruma-identifiers/blob/master/src/user_id.rs#L177

Fixed?