search

rumblefrog / a2s-rs

Rust implementation of Source Query
MIT License
20 stars 14 forks source link

Player's score is unsigned when it should be signed #9

Closed ashort96 closed 3 years ago

ashort96 commented 3 years ago

https://github.com/rumblefrog/a2s-rs/blob/bfb7dd52d8fbbac184ddb64ebb6f7e936a0dbfdd/src/players.rs#L37

In the Server queries documentation from Valve, a player's score is a long, or a signed integer.

rumblefrog commented 3 years ago

Can a player's score really be negative? Doesn't make sense to use signed here despite their documentation.

ashort96 commented 3 years ago

Yep - if a player kills themselves, their score can go negative.

rumblefrog commented 3 years ago

Got it, thanks!