rumcii / emacs-nav

Automatically exported from code.google.com/p/emacs-nav
GNU General Public License v3.0
0 stars 0 forks source link

Review Request #25

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Purpose of code changes on this branch:

1. Fixed quick* buttons. They were not working because of
nav-make-filenames-clickable was voiding them.

2. Renamed directory bookmarks to "quickdir" so not to be confused with
emacs bookmark system. 

3. Removed erroneous comments.
What is the expected output? What do you see instead?

Notes:
Default review request does not work on google code with hg. This is a
known issue. 

Original issue reported on code.google.com by matthew....@gmail.com on 29 Jul 2009 at 12:51

GoogleCodeExporter commented 8 years ago
PLEASE DELETE THIS NON-ISSUE

Original comment by matthew....@gmail.com on 29 Jul 2009 at 1:55

GoogleCodeExporter commented 8 years ago
Looks good except that it would be more useful to have filenames or full paths 
for
the tooltips on the quickthings.

Original comment by issac.tr...@gmail.com on 30 Jul 2009 at 7:34

GoogleCodeExporter commented 8 years ago

Original comment by issac.tr...@gmail.com on 30 Jul 2009 at 7:35

GoogleCodeExporter commented 8 years ago
This can be done with:
(button-type-put 'quickdir-jump-button 'help-echo (nth 0 nav-quickdir-list))

but we would need to create a button type for all 6 quickthings. It's easy to 
do but
would take a of lines.

Original comment by matthew....@gmail.com on 30 Jul 2009 at 7:17