rumkin / pill

Add dynamic content loading to static sites with only 1 KiB of JS

https://rumkin.github.io/pill/

MIT License

383 stars 19 forks source link

Custom events #27

Closed tamb closed 3 years ago

tamb commented 4 years ago

25

tamb commented 3 years ago

@rumkin I believe I've resolved al conflicts

tamb commented 3 years ago

@rumkin Did you see the changes I had made? Wondering where you stand on this PR?

rumkin commented 3 years ago

@tamb I'm analysing the impact of this changes. I had resolved all conversations, so it's on the finish straight.

rumkin commented 3 years ago

You, know I think Pill should emit pill:ready event on pill() call as initial event to signal to another scripts to initialise theirs logic.

This event should be emitted in the end of the pill function call.

tamb commented 3 years ago

You, know I think Pill should emit pill:ready event on pill() call as initial event to signal to another scripts to initialise theirs logic.

This event should be emitted in the end of the pill function call.

That would cause an API discrepancy. onReady and pill:ready are paired already in this pr. Should an additional hook and event be added? If that's the case should this go through and then the API can be augmented in a follow-up PR?

Also, what timezone are you in? I'm EDT

rumkin commented 3 years ago

@tamb. Yep. It's would be proper to finally merge this PR.

I'm in GMT+3.